CLN: Datetimelike._can_hold_na #13983
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sinhrks
added
Missing-data
Current coverage is 85.28% (diff: 100%)@@ master #13983 diff @@
==========================================
Files 139 139
Lines 50543 50547 +4
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 43101 43107 +6
+ Misses 7442 7440 -2
Partials 0 0
|
sinhrks
force-pushed
the
can_hold_na
branch
4 times, most recently
from
ec38c18 to
dbdac92
Compare
sinhrks
changed the title
sinhrks
force-pushed
the
can_hold_na
branch
3 times, most recently
from
70a4e82 to
da4e886
Compare
|
@jreback @jorisvandenbossche can u check? This is needed to make some |
sinhrks
force-pushed
the
can_hold_na
branch
2 times, most recently
from
7e60ff5 to
fb23295
Compare
|
This is looking good to me. @jreback OK? |
|
needs #13979 first |
| """ | ||
| wrap Index._get_unique_index to handle NaT | ||
| """ | ||
| res = super(PeriodIndex, self)._get_unique_index(dropna=dropna) |
There was a problem hiding this comment.
shouldn't this be handled in the super?
|
@sinhrks updated to not rely on that one |
|
@sinhrks This needs a rebase now I merged the other |
|
lgtm. ping on green. |
|
fixed lint error, and now green. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master | flake8 --diffdatetimelike
Index._can_hold_nais allFalseeven though these can storeNaT.Because of
test_base.pycondition below, datetime-like Indexes had skipped some tests until now.